Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picture description #2717

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

sascha-karnatz
Copy link
Contributor

@sascha-karnatz sascha-karnatz commented Feb 8, 2024

What is this pull request for?

Add a description field to the picture model. This description is used to prefill the alt_tag property to display the alt text in picture property dialog. Be aware that this field is only updated after the submitting element form.

Screenshots

Aufnahme 2024-02-08 at 12 18 53@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested review from a team and removed request for alchemycms-bot February 8, 2024 11:35
@tvdeyen
Copy link
Member

tvdeyen commented Feb 8, 2024

@sascha-karnatz nice feature. I think it makes sense to use a textarea for the ingredient picture alt_tag field as well

_picture_fields html erb — alchemy_cms 2024-02-08 12-42-11

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing specs are unrelated and a fix is in #2718

@sascha-karnatz sascha-karnatz force-pushed the add-picture-description branch 3 times, most recently from abd6ad1 to 6fc56c8 Compare February 9, 2024 13:06
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

add a description field to each picture. This field will be used in the picture selector to prefill the alt text.
Use the picture description to prefill the alt_tag if not given. This value is at the moment only available if the editor form is submitted.
@sascha-karnatz sascha-karnatz force-pushed the add-picture-description branch from 6fc56c8 to 1f9fca1 Compare February 12, 2024 07:11
@tvdeyen tvdeyen added this to the 7.2 milestone Feb 12, 2024
@tvdeyen tvdeyen merged commit f302974 into AlchemyCMS:main Feb 12, 2024
34 checks passed
@sascha-karnatz sascha-karnatz deleted the add-picture-description branch February 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants