-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict turbo-rails version #2720
Merged
tvdeyen
merged 1 commit into
AlchemyCMS:main
from
sascha-karnatz:restrict-turbo-rails-version
Feb 9, 2024
Merged
Restrict turbo-rails version #2720
tvdeyen
merged 1 commit into
AlchemyCMS:main
from
sascha-karnatz:restrict-turbo-rails-version
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict turbo-rails version to below 2 to prevent compatibility issue with the new version. These issues will be addressed in one of the future versions.
sascha-karnatz
requested review from
alchemycms-bot and
a team
and removed request for
alchemycms-bot
February 9, 2024 13:16
tvdeyen
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have incompatibility problems? Or is this just precautionary?
Just saw the failing builds 😞 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Feb 12, 2024
[7.1-stable] Merge pull request #2720 from sascha-karnatz/restrict-turbo-rails-version
tvdeyen
added a commit
that referenced
this pull request
Feb 16, 2024
[7.0-stable] Merge pull request #2720 from sascha-karnatz/restrict-turbo-rails-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-to-7.0-stable
Needs to be backported to 7.0-stable
backport-to-7.1-stable
Needs to be backported to 7.1-stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Restrict turbo-rails version to below 2 to prevent compatibility issue with the new version. These issues will be addressed in one of the future versions.
Checklist