Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict turbo-rails version #2720

Merged

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

Restrict turbo-rails version to below 2 to prevent compatibility issue with the new version. These issues will be addressed in one of the future versions.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Restrict turbo-rails version to below 2 to prevent compatibility issue with the new version. These issues will be addressed in one of the future versions.
@sascha-karnatz sascha-karnatz requested review from alchemycms-bot and a team and removed request for alchemycms-bot February 9, 2024 13:16
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have incompatibility problems? Or is this just precautionary?

@tvdeyen tvdeyen merged commit ab9cc52 into AlchemyCMS:main Feb 9, 2024
34 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Feb 9, 2024

Just saw the failing builds 😞

@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.0-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tvdeyen added a commit that referenced this pull request Feb 12, 2024
[7.1-stable] Merge pull request #2720 from sascha-karnatz/restrict-turbo-rails-version
tvdeyen added a commit that referenced this pull request Feb 16, 2024
[7.0-stable] Merge pull request #2720 from sascha-karnatz/restrict-turbo-rails-version
@sascha-karnatz sascha-karnatz deleted the restrict-turbo-rails-version branch February 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants