[7.1-stable] Merge pull request #2750 from tvdeyen/fix-sortable-elements #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that nested elements of all elements get initialized as sortable after being created, not just fixed. (cherry picked from commit df533be)
SortableJS sends two events if you drag an element from one nesteable elements container to another. Leading to incrementing the target lists positions to high. Since acts_as_list maintains both lists correctly we can simply suppress the second event on the source list. (cherry picked from commit fa8a966)
tvdeyen
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.1-stable:Questions ?
Please refer to the Backport tool documentation