Fix order of elements after Page copy #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A page with fixed and non-fixed elements need to copy
each element group individually in order to maintain
the list position, because the acts_as_list scope is
[:page_version_id, :fixed, :parent_element_id]
tvdeyen
added
bug
backport-to-7.0-stable
mamhoff
approved these changes
Feb 27, 2024
sascha-karnatz
approved these changes
Feb 27, 2024
This was referenced Feb 27, 2024
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Feb 27, 2024
[7.1-stable] Merge pull request #2752 from tvdeyen/fix-copy-elements-order
tvdeyen
added a commit
that referenced
this pull request
Feb 27, 2024
[7.0-stable] Merge pull request #2752 from tvdeyen/fix-copy-elements-order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
A page with fixed and non-fixed elements need to copy each element group individually in order to maintain the list position, because the
acts_as_listscope isChecklist