Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Sitemap rake task to detect and fix issues #2774

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

It is possible that, due to exceptions or other unexpected errors, the lft/rgt values and/or the page depth on the pages are not correct. In that case these tasks can help to detect and fix issues in the page sitemap.

Screenshots

Aufnahme 2024-03-07 at 11 14 52@2x
Aufnahme 2024-03-07 at 11 17 23@2x

Aufnahme 2024-03-07 at 11 17 56@2x
Aufnahme 2024-03-07 at 11 18 09@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@sascha-karnatz sascha-karnatz requested a review from a team March 7, 2024 10:20
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! This looks really nice.

lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
lib/tasks/alchemy/sitemap.rake Outdated Show resolved Hide resolved
@tvdeyen tvdeyen added this to the 7.2 milestone Mar 7, 2024
It is possible that, due to exceptions or other unexpected errors, the lft/rgt values and/or the page depth on the pages are not correct. In that case these tasks can help to detect and fix issues in the page sitemap.
@sascha-karnatz sascha-karnatz force-pushed the add-sitemap-rake-task branch from ffeabbf to 2058639 Compare March 8, 2024 07:53
@tvdeyen tvdeyen merged commit 47a6bad into AlchemyCMS:main Mar 8, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants