Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotkeys #2789

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix hotkeys #2789

merged 2 commits into from
Mar 15, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 14, 2024

What is this pull request for?

Fix hotkeys in Admin UI

Notable changes

Rewrites the coffeescript based alchemy.hotkeys.js file into a plain ES module

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner March 14, 2024 10:25
@tvdeyen tvdeyen added the backport-to-7.1-stable Needs to be backported to 7.1-stable label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (50fbd39) to head (787d51f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         222      222           
  Lines        6087     6087           
=======================================
  Hits         5832     5832           
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fixes bugs with latest jQuery version that does not reliably trigger click events
anymore.
@tvdeyen tvdeyen merged commit e6cc0c5 into AlchemyCMS:main Mar 15, 2024
35 checks passed
@tvdeyen tvdeyen deleted the fix-hotkeys branch March 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant