Rebuild Growler into web component #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2795 +/- ##
==========================================
+ Coverage 95.81% 95.88% +0.07%
==========================================
Files 222 223 +1
Lines 6087 6082 -5
==========================================
Hits 5832 5832
+ Misses 255 250 -5 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
growler-esm
branch
4 times, most recently
from
03c8bab to
bdb76ce
Compare
And use this for Rails `flash` messages, `render_message` helper and `Alchemy.growl` notices.
These helpers haven't been used for a long time now.
This helper has not been used since we refactored the upload form. Since this has been marked as private and it serves a very limited scope we can simply remove it.
sascha-karnatz
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds a new
<alchemy-message>web component that is used byAlchemy.growl,render_flash_messageandrender_messagehelpers.Checklist