Picture view fixes #2798
Merged
Picture view fixes #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow a textarea to be used as image caption input. This produces br tags for new lines. The output needs to be html safe in order to allow that.
It is very common in Ruby to pass values as symbols
as well.
ie.
image.url(format: :png)
It was raising a (catched) error before that lead to cryptic
undefined method url for nil errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 223 223
Lines 6082 6082
=======================================
Hits 5832 5832
Misses 250 250 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist