Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden element visibility #2799

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 21, 2024

What is this pull request for?

We recently made sure that all HTML elements with
the hidden class do not display at all. But we want to show elements that are hidden, but dim them. Using a dedicated element-hidden class instead.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

We recently made sure that all HTML elements with
the hidden class do not display at all. But we want to
show elements that are hidden, but dim them. Using
a dedicated element-hidden class instead.
@tvdeyen tvdeyen requested a review from a team as a code owner March 21, 2024 16:53
@tvdeyen tvdeyen added this to the 7.2 milestone Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (659a96c) to head (8e098ee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2799   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         223      223           
  Lines        6082     6082           
=======================================
  Hits         5832     5832           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen enabled auto-merge March 22, 2024 07:47
@tvdeyen tvdeyen merged commit d300b23 into AlchemyCMS:main Mar 22, 2024
35 checks passed
@tvdeyen tvdeyen deleted the fix-hidden-elements branch March 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants