Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Turbo Frame for Elements Window #2801

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 22, 2024

What is this pull request for?

Instead of using our own fetch logic on a DIV container we make use of a Turbo Frame.

For now we need to disable the submit buttons inside,
because we still use Rails UJS and the remote forms
feature that uses js.erb responses from the controller.

Those need to be refactored into Turbo Streams eventually, but
this is too much for now.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

they should not be nested like this
@tvdeyen tvdeyen added this to the 7.2 milestone Mar 22, 2024
@tvdeyen tvdeyen self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (fb34795) to head (857c2b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         224      224           
  Lines        6097     6097           
=======================================
  Hits         5847     5847           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen marked this pull request as ready for review March 22, 2024 17:35
@tvdeyen tvdeyen requested a review from a team as a code owner March 22, 2024 17:35
For now we need to disable the submit buttons inside,
because we still use Rails UJS and the remote forms
feature that uses js.erb responses from the controller.

Those need to be refactored into Turbo Streams, but
this is too much for now.
@tvdeyen tvdeyen force-pushed the turbo-element-window-frame branch from e5f6f9c to 857c2b3 Compare March 22, 2024 21:15
@tvdeyen tvdeyen removed their assignment Mar 25, 2024
@tvdeyen tvdeyen merged commit 349b22a into main Mar 25, 2024
35 checks passed
@tvdeyen tvdeyen deleted the turbo-element-window-frame branch March 25, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants