Use Turbo Frame for Elements Window #2801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of using our own fetch logic on a DIV container we make use of a Turbo Frame.
For now we need to disable the submit buttons inside,
because we still use Rails UJS and the remote forms
feature that uses
js.erb
responses from the controller.Those need to be refactored into Turbo Streams eventually, but
this is too much for now.
Checklist