Add remote Attachment select to Link Dialog #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
attachment-select
branch
from
ed01d87 to
e738d73
Compare
tvdeyen
force-pushed
the
attachment-select
branch
from
e738d73 to
228ee7c
Compare
tvdeyen
force-pushed
the
attachment-select
branch
from
c767c12 to
9007cbc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 225 227 +2
Lines 6143 6185 +42
==========================================
+ Hits 5888 5928 +40
- Misses 255 257 +2 ☔ View full report in Codecov by Sentry. |
Instead of a custom event for each subclass of `Alchemy.RemoteSelect` we fire a custom `Alchemy.RemoteSelect.Change` event. This event then has a `added` and `removed` information on the `detail` object that can be used to act accordingly.
The page select and attachment select allow to clear the selection. In this case we should correctly remove the link.
We need to trick a bit with the width here, because the flex container is calculating 4 items, while we have 5 buttons.
tvdeyen
force-pushed
the
attachment-select
branch
from
9007cbc to
9e3b319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Use a RemoteSelect for attachments in the link dialog. This has a positive impact on load times of the link dialog
for sites with lots of attachments.
Checklist