Use Shoelace Dialog for ConfirmDialog #2823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We have our own Dialog JS class. We should not have a complicated component like this in our code base.
Instead we should use the Shoelace Dialog that has better accessibility and UX.
Since our dialog is meant to load remote content we first migrate its little sister
ConfirmDialog
, which just displays text.This also adds a remixicon theme to shoelace (based on the SVG sprite sheet) and updates Shoelace to 2.15.0 because
of a bug in icon set registration.
Checklist