Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shoelace Dialog for ConfirmDialog #2823

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 4, 2024

What is this pull request for?

We have our own Dialog JS class. We should not have a complicated component like this in our code base.
Instead we should use the Shoelace Dialog that has better accessibility and UX.

Since our dialog is meant to load remote content we first migrate its little sister ConfirmDialog, which just displays text.

This also adds a remixicon theme to shoelace (based on the SVG sprite sheet) and updates Shoelace to 2.15.0 because
of a bug in icon set registration.

Checklist

@tvdeyen tvdeyen added this to the 7.2 milestone Apr 4, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner April 4, 2024 20:17
@tvdeyen tvdeyen force-pushed the shoelace-confirm-dialog branch from ce6dbc8 to 88454b5 Compare April 5, 2024 07:51
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (f0b0403) to head (88454b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2823   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         225      225           
  Lines        6128     6128           
=======================================
  Hits         5878     5878           
  Misses        250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit e2f9520 into AlchemyCMS:main Apr 5, 2024
35 checks passed
@tvdeyen tvdeyen deleted the shoelace-confirm-dialog branch April 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants