Harden Page List Feature Spec #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do a lot of page interaction in this spec, and sometimes there's a race condition: We specify that we want to find stuff `within "table.list"`, and Capybara remembers those elements before the page gets actually reloaded, leading to spec failures like this one: https://github.com/AlchemyCMS/alchemy_cms/actions/runs/8637028349/job/23678297291?pr=2831 Here, the error message was: ``` 1) Admin page list as author can filter table of pages by status Failure/Error: expect(page.find("tr:nth-child(1) td.name", text: "Intro")).to be Capybara::ElementNotFound: Unable to find css "tr:nth-child(1) td.name" with text "Intro" within Obsolete #<Capybara::Node::Element> ``` The hint here was "Obsolete".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 227 227
Lines 6186 6186
=======================================
Hits 5929 5929
Misses 257 257 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a lot of page interaction in this spec, and sometimes there's a race condition: We specify that we want to find stuff
within "table.list", and Capybara remembers those elements before the page gets actually reloaded, leading to spec failures like this one:https://github.com/AlchemyCMS/alchemy_cms/actions/runs/8637028349/job/23678297291?pr=2831
Here, the error message was:
The hint here was "Obsolete".