Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Commit changes to javascript bundles #2851

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 26, 2024

What is this pull request for?

If a dependency has been updated we rebuild
the bundles. After the tests have passed we
commit the changes and skip gh actions for this
commit.

Checklist

tvdeyen added 2 commits April 26, 2024 18:22
Make sure the picture is reloaded from that database
in order to  catch changes.
We want to test if a changed JS dependency breaks our
feature specs.
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (fdc7249) to head (7a46e57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         229      229           
  Lines        6211     6211           
=======================================
  Hits         5954     5954           
  Misses        257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If a dependency has been updated we rebuild
the bundles. After the tests have passed we
commit the changes and skip gh actions for this
commit.
@tvdeyen tvdeyen changed the title Commit js after build CI: Commit changes to javascript bundles Apr 26, 2024
@tvdeyen tvdeyen marked this pull request as ready for review April 26, 2024 20:48
@tvdeyen tvdeyen requested a review from a team as a code owner April 26, 2024 20:48
@tvdeyen tvdeyen merged commit ec89ec4 into main Apr 26, 2024
36 of 37 checks passed
@tvdeyen tvdeyen deleted the commit-js-after-build branch April 26, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant