Use page version's updated_at timestamp as cache key
#2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
==========================================
+ Coverage 95.86% 95.93% +0.07%
==========================================
Files 229 229
Lines 6211 6224 +13
==========================================
+ Hits 5954 5971 +17
+ Misses 257 253 -4 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
May 7, 2024
mamhoff
force-pushed
the
use-updated-at-timestamp-as-cache-key
branch
from
7cdcf7a to
215ba02
Compare
tvdeyen
reviewed
May 8, 2024
mamhoff
force-pushed
the
use-updated-at-timestamp-as-cache-key
branch
2 times, most recently
from
c3ab762 to
de87501
Compare
tvdeyen
approved these changes
May 8, 2024
Currently, it's hard for us to invalidate caches for Alchemy pages when content that's referenced through ingredients with related objects changes. For example, in a situation where a user combines Alchemy and Solidus using the `alchemy_solidus` gem, a page's cache key does not update when a product that's referenced through a SpreeProduct ingredient changes. There's a PR up on the alchemy_solidus gem that touches ingredients in these situations, and with this change, that touching can be used for breaking caches. [1] In the unlikely event the requested version is not available, we use the page's updated_at timestamp as a fallback. The core of the logic has been moved to a new `#last_modified_at` method that can be used for the last-modified header in HTTP responses. [1](AlchemyCMS/alchemy-solidus#108)
mamhoff
force-pushed
the
use-updated-at-timestamp-as-cache-key
branch
3 times, most recently
from
3eb93f9 to
38e4c42
Compare
Without this, the previous commit will not do what we expect. If we don´t update the page version's updated at, it will not serve as a good cache invalidator.
mamhoff
force-pushed
the
use-updated-at-timestamp-as-cache-key
branch
from
38e4c42 to
7383a02
Compare
tvdeyen
reviewed
May 14, 2024
We should not cache empty responses.
tvdeyen
approved these changes
May 14, 2024
mamhoff
force-pushed
the
use-updated-at-timestamp-as-cache-key
branch
from
7597fd6 to
6787e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Currently, it's hard for us to invalidate caches for Alchemy pages when content that's referenced through ingredients with related objects changes.
For example, in a situation where a user combines Alchemy and Solidus using the
alchemy_solidusgem, a page's cache key does not update when a product that's referenced through a SpreeProduct ingredient changes.There's a PR up on the alchemy_solidus gem that touches ingredients in these situations, and with this change, that touching can be used for breaking caches. [1]
1
Checklist