Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for PagesHelper#page_title #2863

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented May 7, 2024

What is this pull request for?

This pushes the spec coverage for the pages_helper to 100%, freeing us of codecov issues.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

This pushes the spec coverage for the pages_helper to 100%, freeing us
of codecov issues.
@mamhoff mamhoff requested a review from a team as a code owner May 7, 2024 15:10
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (cbef269) to head (d7860dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
+ Coverage   95.84%   95.86%   +0.01%     
==========================================
  Files         229      229              
  Lines        6211     6211              
==========================================
+ Hits         5953     5954       +1     
+ Misses        258      257       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😊

@tvdeyen tvdeyen merged commit f6b6ad5 into AlchemyCMS:main May 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants