Tackle deprecations #2865
Merged
Tackle deprecations #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecated these helpers, but kept the specs. Since we do not want to see thess deprecations in our test log we silence it.
We still support Rails 7.0, so we need to adjust per version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2865 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 229 229
Lines 6216 6216
=======================================
Hits 5960 5960
Misses 256 256 ☔ View full report in Codecov by Sentry. |
Do not query the database, because the thread of the browser might be faster.
tvdeyen
force-pushed
the
tackle-deprecations
branch
from
cc95bef to
352db03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.