Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message_for_resource_action #2866

Merged
merged 1 commit into from
May 10, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 9, 2024

What is this pull request for?

Returns a translated message for a flash notice or json response message without assigning it to flash[:notice].

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 7.2 milestone May 9, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner May 9, 2024 17:01
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (6499cd4) to head (c9b7fde).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2866   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         229      229           
  Lines        6216     6218    +2     
=======================================
+ Hits         5960     5962    +2     
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Returns a translated message for a flash notice or json response message
without assigning it to `flash[:notice]`.
@tvdeyen tvdeyen force-pushed the message_for_resource_action branch from f93b387 to c9b7fde Compare May 9, 2024 20:01
tvdeyen added a commit to AlchemyCMS/alchemy_i18n that referenced this pull request May 9, 2024
@tvdeyen tvdeyen merged commit cb56014 into AlchemyCMS:main May 10, 2024
36 checks passed
@tvdeyen tvdeyen deleted the message_for_resource_action branch May 10, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants