Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use select2 for ingredient style select #2868

Merged
merged 1 commit into from
May 10, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 10, 2024

What is this pull request for?

These selects do not have much values or a remote search, so select2 is overhead here.

Checklist

These selects do not have much values or a remote search, so `select2` is overhead here.
@tvdeyen tvdeyen requested a review from a team as a code owner May 10, 2024 11:58
@tvdeyen tvdeyen added this to the 7.2 milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (6499cd4) to head (46a4488).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2868   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         229      229           
  Lines        6216     6216           
=======================================
  Hits         5960     5960           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen enabled auto-merge May 10, 2024 12:05
@tvdeyen tvdeyen disabled auto-merge May 10, 2024 12:05
@tvdeyen tvdeyen merged commit 5f1f046 into main May 10, 2024
36 checks passed
@tvdeyen tvdeyen deleted the ingredients-style-select-no-select2 branch May 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant