Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set url on attachment select if attachment found #2882

Merged
merged 1 commit into from
May 22, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 22, 2024

What is this pull request for?

If we set the URL select2 will try to set the value but cannot find it but will hide the placeholder.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

If we set the URL select2 will try to set the value
but cannot find it but will hide the placeholder.
@tvdeyen tvdeyen requested a review from a team as a code owner May 22, 2024 11:26
@tvdeyen tvdeyen added this to the 7.2 milestone May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (c423ef0) to head (b477c1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2882   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         230      230           
  Lines        6260     6260           
=======================================
  Hits         6006     6006           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit a1e0391 into main May 22, 2024
36 checks passed
@tvdeyen tvdeyen deleted the fix-file-tab-select branch May 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants