Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alchemy_link.plugin): Avoid getting an absolute URL #2885

Merged
merged 1 commit into from
May 23, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 22, 2024

What is this pull request for?

Suddenly the anchor.href attribute returns an absolute URL - at least in Firefox - with the Alchemy Admin URL as base.

We want a relative URL.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Suddenly the `anchor.href` attribute returns an absolute URL
- at least in Firefox - with the Alchemy Admin URL as base.

We want a relative URL.
@tvdeyen tvdeyen requested a review from a team as a code owner May 22, 2024 19:32
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable and removed backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels May 22, 2024
@tvdeyen tvdeyen added this to the 7.2 milestone May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (a1e0391) to head (af84b09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         230      230           
  Lines        6260     6260           
=======================================
  Hits         6006     6006           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen enabled auto-merge May 22, 2024 19:42
@tvdeyen tvdeyen merged commit 8813e4d into AlchemyCMS:main May 23, 2024
38 checks passed
@tvdeyen tvdeyen deleted the fix-tinymce-link-plugibn branch May 23, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants