Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent jumping of toggle button in element window #2888

Merged

Conversation

sascha-karnatz
Copy link
Contributor

@sascha-karnatz sascha-karnatz commented May 23, 2024

What is this pull request for?

The toggle button was jumping if a parent element was marked as hidden and the nested element was not marked as hidden. Now the toggle stays in its position, if a other element above is switched to hidden.

Screenshots

Aufnahme 2024-05-23 at 11 09 30@2x

Aufnahme 2024-05-23 at 11 09 24@2x

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

The toggle button was jumping if a parent element was marked as hidden and the nested element was not marked as hidden. Now the toggle stays in its position, if a other element above is switched to hidden.
@sascha-karnatz sascha-karnatz marked this pull request as ready for review May 23, 2024 09:10
@sascha-karnatz sascha-karnatz requested a review from a team as a code owner May 23, 2024 09:10
@tvdeyen tvdeyen merged commit 2d01c36 into AlchemyCMS:main May 23, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants