Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight search terms in RemoteSelect #2898

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 28, 2024

What is this pull request for?

Makes it more obvious why a entry is in the list and complies to the default highlighting that select2 does if there is no html template rendering function.

Checklist

@tvdeyen tvdeyen added this to the 7.2 milestone May 28, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner May 28, 2024 09:54
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (98293af) to head (01bd3e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2898   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         230      230           
  Lines        6269     6269           
=======================================
  Hits         6016     6016           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makes it more obvious why a entry is in the list and complies
to the default highlighting that select2 does if there is no
html template rendering function.
@tvdeyen tvdeyen force-pushed the highlight-select2-search-terms branch from 0fcbbc8 to 01bd3e9 Compare May 28, 2024 10:28
@tvdeyen tvdeyen merged commit 7fc489a into main May 28, 2024
36 checks passed
@tvdeyen tvdeyen deleted the highlight-select2-search-terms branch May 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants