This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Error handling for reading runes on multiselect #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIGHUP is ignored and the program gets into a weird loop waiting for select to happen. Steps to reproduce: `go run examples/longmulti.go` In a different terminat run `kill -s hup (pidof longmulti)` Or simply close the terminal while the program waits for input. The program is not killed and gets in a weird state slowly killing your CPU
Error handling for inputs
|
Oh damn, nice catch! Do you mind looking at the other prompts to make sure we dont have the same problem? |
|
Already checked and also tested. They all look good. Only multiselect got missed. |
|
Sweet! Thanks for fixing this |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGHUP is ignored and the program gets into a weird loop waiting for select to happen.
Steps to reproduce:
go run examples/longmulti.goIn a different terminat run
kill -s hup (pidof longmulti)Or simply close the terminal while the program waits for input.The program is not killed and gets in a weird state slowly killing your CPU