This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
fix(transform): fix nil returned by TransformString #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TranformString should not return
nil
on zero value, otherwisenil
will be passed to next Tranformer if there are more than 1 Transformer in ComposeTransformers.In next TranformString, while checking if if value is zero at
survey/validate.go
Line 86 in e64d9b6
reflect.ValueOf(nil).Interface()
andreflect.Zero(reflect.ValueOf(nil).Type()).Interface()
will cause program to panicTo fix:
return zero value of string (
""
) instead coz String Tranformer is guaranteed to return stringfix #329