This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes restoring the state of the cursor when an error occurs when detecting terminal size.
fixes #282
Piped stdin is still not handled correctly:
The problem here is, that with piped stdin,
Cursor.Location()
fails withio.EOF
:survey/terminal/cursor.go
Lines 106 to 109 in f45c05b
Subsequently, no input is read, and control commands printed instead of being applied.
I'm not exactly sure how a piped stdin differs from a terminal stdin, so I don't know how to fix this.
One step surely would be to change
Cursor
, so that it detects piped stdin, and switches to a NO-OP mode?If this can't be fixed properly, the README should clearly state that using survey with piped stdin breaks the application.