Merge pull request #48 from ncjones/real-error-obj

Make rejected promise always yield error instance
AleksandrRogov · May 3, 2019 · 3ef9e2a · 3ef9e2a
2 parents 80cf08a + c5b2e85
commit 3ef9e2a
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lib/requests/http.js b/lib/requests/http.js
@@ -88,21 +88,25 @@ var httpRequest = function (options) {
                     break;
                 }
                 default: // All other statuses are error cases.
-                    var error;
+                    var crmError;
                     try {
                         var errorParsed = JSON.parse(rawData);
 
-                        error = errorParsed.hasOwnProperty('error') && errorParsed.error
+                        crmError = errorParsed.hasOwnProperty('error') && errorParsed.error
                             ? errorParsed.error
                             : { message: errorParsed.Message };
                     } catch (e) {
                         if (rawData.length > 0) {
-                            error = { message: rawData };
+                            crmError = { message: rawData };
                         }
                         else {
-                            error = { message: "Unexpected Error" };
+                            crmError = { message: "Unexpected Error" };
                         }
                     }
+                    var error = new Error();
+                    Object.keys(crmError).forEach(k => {
+                      error[k] = crmError[k];
+                    })
                     error.status = res.statusCode;
                     error.statusText = request.statusText;
                     errorCallback(error);