Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate keys does not allow to use integer value (it is forcing to use a string) #38

Closed
mfradcourt opened this issue Nov 13, 2018 · 1 comment

Comments

@mfradcourt
Copy link
Contributor

mfradcourt commented Nov 13, 2018

The current validation in the keyParameterCheck(...) function is forcing the key parameters to be of type string but it may happen that an integer is used.

For example, when a field is a drop down in Dynamics, the value behind is an integer.
var key = "xxx='123456',yyy='137891',select_option=959600000"

The Dynamics CRM API is expecting to receive the value without single quote in case of an integer value.

I'm preparing a PR so no need to worry too much about this, just logging an issue so there is a trace about the feature/bug :-)

AleksandrRogov added a commit that referenced this issue Nov 13, 2018
#38 Alternate keys does not allow to use integer value (it is forcing to use a string)
@AleksandrRogov
Copy link
Owner

Thanks @mfradcourt for submitting this issue and creating a pull request! I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants