-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/rpc request serde #1539
Merged
raychu86
merged 5 commits into
AleoNet:testnet2
from
whalelephant:fix/rpc-request-serde
Jan 13, 2022
Merged
Fix/rpc request serde #1539
raychu86
merged 5 commits into
AleoNet:testnet2
from
whalelephant:fix/rpc-request-serde
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelephant
force-pushed
the
fix/rpc-request-serde
branch
from
January 10, 2022 13:57
98d72cc
to
77ac195
Compare
The CI doesn't want to start; I'll try reopening, it sometimes helps. |
Did it get stuck again? Let me retry. |
ljedrz
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
raychu86
approved these changes
Jan 12, 2022
raychu86
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1369 without introducing new dependencies with jsonrpc-* crates.
There is an issue with parsing numerical value with json rpc id field. The work around implemented is to first parse into
serde_json::Value
as suggested here.Another PR to the temp dependency json-rpc-type fixes the issue of how
serde_json::Value
string deserialization requires escaping and cannot therefore be cast to a borrowed str type.Test Plan
Related PRs
#1496
#1537