-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test targets #3378
feat: test targets #3378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you update the Cargo.toml to the rev of AleoNet/snarkVM#2529 (which is just for illustrative purposes, as the maintainer will have to update it anyway)
a7faa94
to
05d142d
Compare
Does this apply to compiled |
@raychu86 I've updated the description. Let me know if still not clear. |
So if We need some sort of enforcement that the |
05d142d
to
ca04d15
Compare
ca04d15
to
25631ef
Compare
#path = "../snarkVM" | ||
git = "https://github.com/AleoNet/snarkVM.git" | ||
rev = "be171ce" # If this is updated, the rev in `node/rest/Cargo.toml` must be updated as well. | ||
git = "https://github.com/joske/snarkVM.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: snarkOS will no longer be using AleoNet
's implementation of snarkVM after this PR.
Proceed with caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joske I'm guessing this was changed for testing purposes and we can change it back to AleoNet
's snarkVM ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And merge AleoNet/staging + run cargo fmt
🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was because the snarkVM PR needs to be merged first. It was always intended that it be changed to an Aleonet snarkVM repo before merging this.
Superseded by #3424 to resolve merge conflict |
NOTE: this was not actually merged, must be a bug in Github since the branchname is the same as the superseding PR. |
Motivation
Add feature flag to be able to lower coinbase and proof targets for testing purposes. This feature flag will lower the proof and coinbase targets to 8 and 32 respectively.
The feature flag needed to be cascaded to all dependencies of snarkVM to be sure everything uses same constants.
To use, compile with
--features test_targets
e.g.
Test Plan
tested by using tx-cannon and adding println to verify correct targets.
CI link
Related PRs
Must first merge AleoNet/snarkVM#2529 and the snarkVM revision must be updated in snarkOS in 2 places before merging this.