[Feature] Adds a histogram label #2357
Conversation
|
@collinc97 can you adjust the settings so we can add @miazn as reviewer? |
|
We can actually remove |
metrics/src/lib.rs
Outdated
| @@ -98,3 +98,17 @@ pub fn histogram<V: Into<f64>>(name: &'static str, value: V) { | |||
| let histogram = ::metrics::histogram!(name); | |||
| histogram.record(value.into()); | |||
| } | |||
|
|
|||
| pub fn histogram_label<V: Into<f64>>(name: &'static str, label_key: &'static str, label_value: String, value: V) { | |||
| let labels = vec![::metrics::Label::new(label_key, label_value)]; | |||
There was a problem hiding this comment.
if we are only using a string label key and value, it might be easier to just use the macro, as i did here:
https://github.com/AleoHQ/snarkOS/pull/3064/files#diff-8663d09365b76641c32c45870cbd1915ab198258eb6b823b0aa779128a5b4ff1R93
this makes it cleaner to add the label function to the other two types (counter and gauge), which we should probably do?
There was a problem hiding this comment.
Indeed, now I switched to owned string for the label value, it's possible to use the macro. This was giving trouble with 'static when it was still a &str.
There was a problem hiding this comment.
I could add label variants to the gauge and counter too, but there's no need at the moment?
|
I kept the register functions for backwards compatibility. They were already useless when we bumped to |
joske
force-pushed
the
feat/histogram_labels
branch
from
ecf291e
to
839175e
Compare
Motivation
This adds a
histogram_labelmethod to allow passing a label to the histogram. A limitation is that you can only attach one label.