Improve location of some compiler errors #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn parse_assign_from_str<T>(input: ParseStream) -> Result<T> where T: Parse { | ||
| input.parse::<Token![=]>()?; | ||
| match Lit::parse(input)? { | ||
| Lit::Str(string) => string.parse(), |
There was a problem hiding this comment.
In case of failure, this will point inside the string, rather than after it
There was a problem hiding this comment.
Before:
After:
| use crate::utils::{parse_attrs, parse_docs}; | ||
|
|
||
| #[derive(Default)] | ||
| pub struct FieldAttr { | ||
| pub type_as: Option<String>, | ||
| pub type_as: Option<Path>, |
There was a problem hiding this comment.
This enables checking if the string contains valid syntax for a path
macros/src/types/named.rs
Outdated
| @@ -93,11 +93,11 @@ fn format_field( | |||
| } | |||
|
|
|||
| if type_as.is_some() && type_override.is_some() { | |||
| syn_err!("`type` is not compatible with `as`") | |||
| syn_err!(field.ident.span(); "`type` is not compatible with `as`") | |||
There was a problem hiding this comment.
Not quite where I'd like the error to show up, but it's the best I could do, at least pointing the user at the correct field
There was a problem hiding this comment.
Alternatively, I can make it so the entire field is marked, attributes, identifier and type, by using syn::Error::new_spanned
Before:
After:
escritorio-gustavo
changed the title
|
This is great, love it! |
NyxCode
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves where the compiler error points when there is an attribute error.
This errors now point at the exact location they should
#[ts(as = "...")]attribute would point at the token after the string when receiving invalid path syntax#[ts(optional = nullable)]would do the same when receiving anything other thannullableErrors about incompatible attributes point at the entire field definition