-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency caching to GH Actions for faster CI #258
Conversation
Our CI takes quite a while to run, mostly because of the Rust compiler being kinda slow. This PR attempts to remedy that by caching its dependencies. The caveat is... I have no idea if it will actually work
Okay, first CI run finished in 2m 30s. We have a few dead code warnings in our tests, I'll add |
2m 22s... that's disappointing |
I think it's not caching because it has to compile both |
Oops, running these tests in parallel breaks them due to everyone messing with the same files |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Well, I finally got CI to run again |
This comment was marked as outdated.
This comment was marked as outdated.
Finally! Got the time down to 1m06s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also runs twice on every commit when we do PR's from within the repo, this PR also fixes that.
🥳
Great change, super happy to see this!
To keep main clean, it'd be nice if you could squash the commits.
Agreed, this has way too many commits for something that really should be simple |
Our CI takes quite a while to run, mostly because of the Rust compiler being kinda slow. This PR attempts to remedy that by caching its dependencies. It also runs twice on every commit when we do PR's from within the repo, this PR also fixes that.
I have no idea if it will actually work, but should be worth the shot