Generate somewhat cleaner TypeList
s
#292
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #291, #289
Goal
Generate
TypeList
s containing less duplicates. This speeds up generation of imports, and avoids rustc recursion limits.This does not aim to fix the "recursion limit" problem completely. Before, ~128 types caused the issue, while now, it'd only be caused by ~128 unique types.
Changes
Dependencies
to manually track "direct", "transitive" and "generics" dependencies, only generating rust code at the very end.TODOs
Rc
s to avoid excessive cloning, but a better data structure would probably help hereTypeList
is a cleaner approachToTokens
implChecklist