Corrige inconsistências no README #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fccoelho
requested changes
Nov 25, 2024
| **Reading `.dbc` file:** | ||
|
|
||
| ```python | ||
| >>> from pysus.utilities.readdbc import read_dbc |
There was a problem hiding this comment.
It's true that this function no longer exists within pysus, but for people that have standalone DBC files they can still use the pyreaddbc.read_dbc Perhaps this example could be modified to just fix the import, and be kept in the README
There was a problem hiding this comment.
But this function is not even there. There are open issues about it in the repo, too.
>>> from pyreaddbc import read_dbc
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: cannot import name 'read_dbc' from 'pyreaddbc' (/Users/ccc/Library/Caches/pypoetry/virtualenvs/pysus-Np31jkgz-py3.11/lib/python3.11/site-packages/pyreaddbc/__init__.py)
>>> from pyreaddbc import readdbc
>>> filename = '~/Downloads/DOAC2023.dbc'
>>> readdbc(filename, encoding='iso-8859-1')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: 'module' object is not callable
There was a problem hiding this comment.
You are right. I am going to fix this, by re-adding this function to Pyreaddbc. I think it's useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR corrige imports e remove chamada a função que não existe no README.
A chamada para download dos arquivos do SINAN requer instalação das dependências do
geo, reportada em #207.