SpotBugsの警告対応 (#1693)

AlesInfiny · Dec 11, 2024 · e44bb72 · e44bb72
1 parent ed2451a
commit e44bb72
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/...st/java/com/dressca/applicationcore/applicationservice/CatalogApplicationServiceTest.java b/...st/java/com/dressca/applicationcore/applicationservice/CatalogApplicationServiceTest.java
@@ -43,6 +43,8 @@ public class CatalogApplicationServiceTest {
 
   private CatalogApplicationService service;
 
+  private static final Random random = new Random();
+
   @BeforeEach
   void setUp() {
     service = new CatalogApplicationService(messages, catalogRepository, brandRepository, catalogCategoryRepository);
@@ -106,7 +108,6 @@ void setUp() {
   }
 
   private CatalogItem createCatalogItem(long id) {
-    Random random = new Random();
     long defaultCatalogCategoryId = random.nextInt(1000);
     long defaultCatalogBrandId = random.nextInt(1000);
     String defaultDescription = "Description.";

diff --git a/...t/java/com/dressca/applicationcore/applicationservice/ShoppingApplicationServiceTest.java b/...t/java/com/dressca/applicationcore/applicationservice/ShoppingApplicationServiceTest.java
@@ -64,6 +64,8 @@ public class ShoppingApplicationServiceTest {
 
   private ShoppingApplicationService service;
 
+  private static final Random random = new Random();
+
   @BeforeEach
   void setUp() {
     service = new ShoppingApplicationService(messages, basketRepository, catalogRepository, orderRepository,
@@ -382,7 +384,6 @@ private List<OrderItem> createDefaultOrderItems() {
   }
 
   private CatalogItem createCatalogItem(long id) {
-    Random random = new Random();
     long defaultCatalogCategoryId = random.nextInt(1000);
     long defaultCatalogBrandId = random.nextInt(1000);
     String defaultDescription = "Description.";

diff --git a/...tion-core/src/test/java/com/dressca/applicationcore/catalog/CatalogDomainServiceTest.java b/...tion-core/src/test/java/com/dressca/applicationcore/catalog/CatalogDomainServiceTest.java
@@ -27,6 +27,8 @@ public class CatalogDomainServiceTest {
   @InjectMocks
   private CatalogDomainService service;
 
+  private static final Random random = new Random();
+
   @Test
   void testGetExistCatalogItems_正常系_リポジトリのfindByCategoryIdInを1度だけ呼出す() {
     // Arrange
@@ -122,7 +124,6 @@ public class CatalogDomainServiceTest {
   }
 
   private CatalogItem createCatalogItem(long id) {
-    Random random = new Random();
     long defaultCatalogCategoryId = random.nextInt(1000);
     long defaultCatalogBrandId = random.nextInt(1000);
     String defaultDescription = "Description.";