-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace inline style by hidden attribute... #66
base: master
Are you sure you want to change the base?
Conversation
Rethinking... My code is retro-compatible only in case the style is set inline. I guess I should change it. |
FIXED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can drop IE8 support now and use classList
Please remove yarn.lock
since I now prefer package-lock.json :)
Are you sure? Move to v3 just because of that? No adding tests? I guess we could, at least, add code linting. Of course, keeping the simplicity and the small size.
|
I will take some time to clean that with my eslint ruleset IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something? |
Let's use Airbnb! It's a standard.
Changes of support are MAJOR, but as that's already done on v2, I guess we can just update the README. I wouldn't reduce support for things so simple to resolve, but you're the boss! |
We could move to ESBuild as well. |
The constant of the world is to change, @Alex-D . |
...in a retro compatible way
closes #48