Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inline style by hidden attribute... #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robsonsobral
Copy link

...in a retro compatible way

closes #48

@robsonsobral
Copy link
Author

Rethinking... My code is retro-compatible only in case the style is set inline. I guess I should change it.

@robsonsobral
Copy link
Author

FIXED.

Copy link
Owner

@Alex-D Alex-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can drop IE8 support now and use classList

Please remove yarn.lock since I now prefer package-lock.json :)

src/cookies-eu-banner.js Outdated Show resolved Hide resolved
@robsonsobral
Copy link
Author

robsonsobral commented Mar 22, 2022

I think I can drop IE8 support now and use classList

Are you sure? Move to v3 just because of that? No adding tests? I guess we could, at least, add code linting. Of course, keeping the simplicity and the small size.


dataset is also IE10+

@Alex-D
Copy link
Owner

Alex-D commented Mar 22, 2022

I will take some time to clean that with my eslint ruleset

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

@robsonsobral
Copy link
Author

I will take some time to clean that with my eslint ruleset

Let's use Airbnb! It's a standard.

IE8 is not supported in v2 since I already use classList and dataset, so what is wrong to keep them? I just need to update the README to remove IE8 from the list and go with IE10+ or did I miss something?

Changes of support are MAJOR, but as that's already done on v2, I guess we can just update the README.

I wouldn't reduce support for things so simple to resolve, but you're the boss!

@robsonsobral
Copy link
Author

We could move to ESBuild as well.

@robsonsobral
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom display property
2 participants