Add link popup "URL" to translatable strings #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So people can add a different label if they want to.
I've made it backwards compatible by adding the `|| 'URL'` since no translation file has this string yet.
People can then override this string by overriding the translation. eg:
`
($ as any).trumbowyg.langs.nl = {
...($ as any).trumbowyg.langs.nl,
url: 'Link',
target: 'Open in',
};
`
Alex-D
reviewed
May 5, 2020
| @@ -1276,7 +1276,7 @@ Object.defineProperty(jQuery.trumbowyg, 'defaultOptions', { | |||
|
|
|||
| var options = { | |||
| url: { | |||
| label: 'URL', | |||
| label: t.lang.linkUrl || 'URL', | |||
There was a problem hiding this comment.
because the 'URL' string is used in other locations in your code and if you want to replace those as well, they might collide. eg: image URL
The translation of 'URL' in the context of a link might have a different translation than the 'URL' in context of an image url in various languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So people can add a different label if they want to.
I've made it backwards compatible by adding the
|| 'URL'since no translation file has this string yet.