openModalInsert fixes and enhancements for issue 709 #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where, if a name is provided which is different to the fieldName, an exception was thrown in the OK button handler. When populating the results in values, use name (if provided) rather than the fieldName. Explicitly support radio buttons (multiple type:'radio' options with the same name), returning the name element in values to the value of the selected radio button. To compensate a little for the few extra lines of code, optimise the $.each which builds the dialog html slightly. Add a little more documentation in docs/documentation/core/index/html and docs/documentation/index.html (I was not sure whether one was generated automatically from the other, so updated both). *** NOTE *** I have not updated any of the files in dist. I assume that is done as part of the release process.
|
Looks good to me, but I need to test it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where, if a name is provided which is different to the fieldName, an exception was thrown in the OK button handler.
When populating the results in values, use name (if provided) rather than the fieldName.
Explicitly support radio buttons (multiple type:'radio' options with the same name), returning the name element in values to the value of the selected radio button.
To compensate a little for the few extra lines of code, optimise the $.each which builds the dialog html slightly.
Add a little more documentation in docs/documentation/core/index/html and docs/documentation/index.html (I was not sure whether one was generated automatically from the other, so updated both).
*** NOTE ***
I have not updated any of the files in dist. I assume that is done as part of the release process.
Issue 709 refers.