Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for minimal links and auto-prefixing http protocol #727

Merged
merged 14 commits into from
Apr 9, 2018
Merged

Add options for minimal links and auto-prefixing http protocol #727

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a4d97c6
Add options to prefix links with protocol and show minimal link popup
SDRACK Jan 30, 2018
7b5777b
Update prefix option name to reflect 'http' protocol usage
SDRACK Jan 30, 2018
9a698cb
Scope minimalLinks option
SDRACK Jan 30, 2018
2658e0e
Update prependHttpPrefix to allow relative links and anchors
SDRACK Feb 28, 2018
89e3b3a
Merge 2.9.5
SDRACK Feb 28, 2018
535a28f
Correct code indentation
SDRACK Feb 28, 2018
fc2bf7a
Revert to correct version
Mar 1, 2018
c0ad1cb
Allow URLs to contain '@'; remove ES6 code.
SDRACK Mar 2, 2018
07e85ca
Merge branch 'develop' of https://github.com/SDRACK/Trumbowyg into de…
SDRACK Mar 2, 2018
7334fbe
Change url prefix option to urlProtocol; allow this to take bool or s…
Mar 5, 2018
5cfecb2
Switch to use regex.test for consistency
Mar 5, 2018
8a0748f
Update to improve urlPrefix setup
Mar 5, 2018
8463bff
Shorten setupUrlPrefix; allow any string as prefix
SDRACK Mar 15, 2018
1b35805
Update docs to cover urlProtocol and minimalLinks options
SDRACK Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/trumbowyg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,16 +480,10 @@ Object.defineProperty(jQuery.trumbowyg, 'defaultOptions', {

if(!protocol) { return; }

if(typeof(protocol) === 'boolean') {
return 'https://'
} else if(typeof(protocol) === 'string') {
if(/^https?:\/\/$/.test(protocol)) { return protocol; }

if(/^https?$/.test(protocol)) {
return protocol + '://'
}
}
}
if(typeof(protocol) !== 'string') { return 'https://'; }
if(/^https?:\/\/$/.test(protocol)) { return protocol; }
if(/^https?$/.test(protocol)) { return protocol + '://'; }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of code to just get https:// or http:// :/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about others protocols? If I want put some ftp:// or whatever?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alex-D.

Would you prefer to allow any string value in the option, and append :// if it's missing?

So:

  • a true value defaults to https://
  • a string without the correct suffix has :// appended to it
  • a string with the correct suffix is prepended as is

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I think it could be cool :)

},

buildEditor: function () {
var t = this,
Expand Down Expand Up @@ -1230,7 +1224,7 @@ Object.defineProperty(jQuery.trumbowyg, 'defaultOptions', {
},
text: {
label: t.lang.text,
value: new XMLSerializer().serializeToString(documentSelection.getRangeAt(0).cloneContents())
value: text
}
};
if (!t.o.minimalLinks) {
Expand Down