-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for minimal links and auto-prefixing http protocol #727
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a4d97c6
Add options to prefix links with protocol and show minimal link popup
SDRACK 7b5777b
Update prefix option name to reflect 'http' protocol usage
SDRACK 9a698cb
Scope minimalLinks option
SDRACK 2658e0e
Update prependHttpPrefix to allow relative links and anchors
SDRACK 89e3b3a
Merge 2.9.5
SDRACK 535a28f
Correct code indentation
SDRACK fc2bf7a
Revert to correct version
c0ad1cb
Allow URLs to contain '@'; remove ES6 code.
SDRACK 07e85ca
Merge branch 'develop' of https://github.com/SDRACK/Trumbowyg into de…
SDRACK 7334fbe
Change url prefix option to urlProtocol; allow this to take bool or s…
5cfecb2
Switch to use regex.test for consistency
8a0748f
Update to improve urlPrefix setup
8463bff
Shorten setupUrlPrefix; allow any string as prefix
SDRACK 1b35805
Update docs to cover urlProtocol and minimalLinks options
SDRACK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of code to just get
https://
orhttp://
:/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about others protocols? If I want put some ftp:// or whatever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Alex-D.
Would you prefer to allow any string value in the option, and append
://
if it's missing?So:
true
value defaults tohttps://
://
appended to itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I think it could be cool :)