Added custom font size option #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History is not working here. Would no work using the trombowyg exexCmd function, so used jQuery instead.
|
Remove commented code and console.log |
|
Updated |
pavelloz
reviewed
Mar 18, 2018
| hasIcon: false | ||
| }; | ||
| trumbowyg.addBtnDef(freeSizeButtonName, freeSizeBtnDef); | ||
| dropdown.push('fontsize_custom'); |
There was a problem hiding this comment.
Since its already assigned, i would use freeSizeButtonName:
dropdown.push(freeSizeButtonName);There was a problem hiding this comment.
I'll give this a shot
pavelloz
reviewed
Mar 18, 2018
| } | ||
| }, | ||
| function (values) { | ||
| var text = trumbowyg.range.startContainer.parentElement |
Added ;
Added translations
|
This works, I added translations too. |
blufish
commented
Apr 5, 2018
| hasIcon: false | ||
| }; | ||
| trumbowyg.addBtnDef(freeSizeButtonName, freeSizeBtnDef); | ||
| dropdown.push('fontsize_custom'); |
There was a problem hiding this comment.
I'll give this a shot
Alex-D
approved these changes
Apr 9, 2018
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History is not working here. Would not work using the trombowyg exexCmd function, so used jQuery instead.