Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for cleanpaste #883

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Fix for cleanpaste #883

merged 3 commits into from
Nov 21, 2018

Conversation

Geniekort
Copy link

Solving the bug as described in #881 , by adding a timeout to the execution in of the cleanpaste plugin.

@Alex-D Alex-D self-requested a review November 19, 2018 23:54
Alex-D
Alex-D requested changes Nov 19, 2018
View reviewed changes
Copy link
Owner

@Alex-D Alex-D left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to fix like that? You are just delaying a push in an array :/

Try to put the setTimeout around the try catch.

@Geniekort
Copy link
Author

You are right, this should fix it

@Alex-D
Copy link
Owner

Alex-D commented Nov 20, 2018

Did you test it?

@Geniekort
Copy link
Author

Yes I tested it. It would be nice if we had some specs to run for Trumbowyg. Nice to see that you are actively developing it!

@Alex-D
Copy link
Owner

Alex-D commented Nov 21, 2018

I hope unit-test/spec for v3 :)

@Alex-D Alex-D merged commit be2a047 into Alex-D:develop Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-D Alex-D Alex-D requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geniekort @Alex-D