New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include npm v10 in package.json engines #19

Open

atuttle wants to merge 1 commit into AlexChesters:main from atuttle:patch-1

atuttle commented Nov 28, 2023

Installing this module with npm v10 currently prints the following warning:

npm WARN config production Use `--omit=dev` instead.
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'rss-url-parser@3.0.0',
npm WARN EBADENGINE   required: { node: '^16 || ^18 || ^20', npm: '9.x.x' },
npm WARN EBADENGINE   current: { node: 'v18.18.0', npm: '10.2.0' }
npm WARN EBADENGINE }

I don't see why npm v10 would be a problem (seems to be working fine for me), so here's a PR to add v10 to the allow-list.


          include npm v10 in package.json engines

c3c2551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet