Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ESM source module #10

Merged
merged 2 commits into from
Oct 9, 2020
Merged

add ESM source module #10

merged 2 commits into from
Oct 9, 2020

Conversation

mojoaxel
Copy link
Collaborator

@mojoaxel mojoaxel commented Oct 7, 2020

This fixes #9

I did the following in this MR:

  • convert keycharm.js from UMD to ESM module.
  • moved the new ESM module source file to the src folder.
  • added a rollup build script to bundle the ESM module to UMD.
  • documanted the differnet imports in the README

I would recommend publishing this as a minor change, because the old keycharm.js file is still there and still supports UMD.

@AlexDM0
Copy link
Owner

AlexDM0 commented Oct 9, 2020

Looks good, thnx!

@AlexDM0 AlexDM0 merged commit 730ce72 into AlexDM0:master Oct 9, 2020
@AlexDM0
Copy link
Owner

AlexDM0 commented Oct 9, 2020

I've published this as 0.4.0. Cheers!

@mojoaxel mojoaxel added the hacktoberfest-accepted hacktoberfest.digitalocean.com label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export also as ESM module
2 participants
@mojoaxel @AlexDM0