added old_implicit_casting settings to the database settings page

AlexR2D2 · Apr 1, 2024 · d581928 · d581928
1 parent 48ce6cf
commit d581928
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/resources/metabase-plugin.yaml b/resources/metabase-plugin.yaml
@@ -1,6 +1,6 @@
 info:
   name: Metabase DuckDB Driver
-  version: 1.0.0-SNAPSHOT-0.1.12
+  version: 1.0.0-SNAPSHOT-0.1.13
   description: Allows Metabase to connect to DuckDB databases.
 contact-info:
   name: Alexander Golubov
@@ -19,6 +19,11 @@ driver:
       display-name: Establish a read-only connection
       default: false
       type: boolean
+    - name: old_implicit_casting
+      display-name: Use old_implicit_casting
+      default: false
+      type: boolean
+
 init:
   - step: load-namespace
     namespace: metabase.driver.duckdb

diff --git a/src/metabase/driver/duckdb.clj b/src/metabase/driver/duckdb.clj
@@ -12,13 +12,13 @@
 (driver/register! :duckdb, :parent :sql-jdbc)
 
 (defmethod sql-jdbc.conn/connection-details->spec :duckdb
-  [_ {:keys [database_file, read_only], :as details}]
+  [_ {:keys [database_file, read_only, old_implicit_casting], :as details}]
   (let [conn_details (merge
    {:classname         "org.duckdb.DuckDBDriver"
     :subprotocol       "duckdb"
     :subname           (or database_file "")
     "duckdb.read_only" (str read_only)
-    "old_implicit_casting" "true"}
+    "old_implicit_casting" (str old_implicit_casting)}
    (dissoc details :database_file :read_only :port :engine))]
    conn_details))