Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the SST image output #239

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

keduba
Copy link
Contributor

@keduba keduba commented Nov 26, 2023

I changed the CMEMS output file example_SST_CMEMS.png to example_SST_CMEMS_fix.png. The first one had the string "time" in the title instead of the actual time of the file "2008-01-01T00:00:00".

Then I modified the tutorial image alt-text and link to point to the new file.

@Alexander-Barth
Copy link
Owner

Thanks, Kene, but the file is actually automatically generated by running the code. Maybe there is conflict with the julia function time and the time variable need to be renamed (e.g. SST_time) ?

@keduba
Copy link
Contributor Author

keduba commented Nov 28, 2023

Okay. So I'll just test it with reverting and renaming the time variable and see if it works.
I'm also assuming the actual file that is run is a .jl file not the tutorials.md.

@keduba
Copy link
Contributor Author

keduba commented Nov 28, 2023

Okay. So I'll just test it with reverting and renaming the time variable and see if it works. I'm also assuming the actual file that is run is a .jl file not the tutorials.md.

Never mind. I realised it's quoted in a code block. I've effected the change and will submit a new PR. Thank you.

@Alexander-Barth
Copy link
Owner

Thanks!

@Alexander-Barth
Copy link
Owner

Thank for the fix!

@Alexander-Barth Alexander-Barth merged commit bad33fa into Alexander-Barth:master Dec 1, 2023
3 of 14 checks passed
@keduba keduba deleted the tutorial-fix branch December 1, 2023 21:30
@keduba keduba restored the tutorial-fix branch December 1, 2023 21:31
@keduba
Copy link
Contributor Author

keduba commented Dec 2, 2023

Hi Alex, I just checked. The generated plot still has the same issue. Could it be that it's just pointing to the previous plot and not generating it afresh ?

@Alexander-Barth
Copy link
Owner

Thanks a lot for letting me know. I just fixed it manually.
9f198d0

@keduba keduba deleted the tutorial-fix branch December 4, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants