replace PyPDF2 by pypdf #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdbarnesUCSD any chance for a quick review and merge? I think the change is quite straightforward? |
|
Hi @FelixMoelder and @johanneskoester, Thanks for opening the pull request after having identified that there was an issue with installing this package via bioconda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
PyPDF2-dependency bypypdfto increase compatibility as the former dependency is depreciated.The replacement should be easily possible as
pyPDF2=3.0andpypdf=3.1are identical (https://github.com/py-pdf/pypdf/releases/tag/3.1.0).Further explanation on why this is helpful can be found in a corresponding issue (#128).