Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar-menu: menu-file path is not expanded #3490

Closed
jlebras opened this issue Jul 30, 2024 · 1 comment
Closed

waybar-menu: menu-file path is not expanded #3490

jlebras opened this issue Jul 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jlebras
Copy link

jlebras commented Jul 30, 2024

Hello, new user of waybar there, thank you for your work !

I followed the documentation about waybar menu configuration but somehow was unable to display a menu when clicking (actually waybar segfaults).

After digging the logs, I found that waybar could not find the xml file describing the menu as a GtkBuilder.
The path used was identical to the one from the doc (~/.config/waybar/power_menu.xml), I tried with $HOME and same thing.

The waybar log shows the path "as-is" without path expansion so I guess there is no expansion at all on the string provided.
After providing a full path it worked.

I looked quickly at the code and the file is opened there without any processing of the path from the config.

I don't know if it's a bug or intended behaviour (could be handy though).

@github-actions github-actions bot added the bug Something isn't working label Jul 30, 2024
yangyingchao added a commit to yangyingchao/Waybar that referenced this issue Aug 1, 2024
yangyingchao added a commit to yangyingchao/Waybar that referenced this issue Aug 1, 2024
@yangyingchao
Copy link
Contributor

I wasn't aware of this feature before, but I would like to use it. Therefore, I have opened a PR for this :)

It does not hurt to expand the filepath anyway.

@Alexays Alexays closed this as completed in 7ec1343 Aug 5, 2024
Alexays added a commit that referenced this issue Aug 5, 2024
fix #3490: expand menu file before opening it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants