Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for group name #2

Closed
wants to merge 1 commit into from
Closed

Add filter for group name #2

wants to merge 1 commit into from

Conversation

TobseF
Copy link

@TobseF TobseF commented Aug 2, 2024

I wanted to check only our updates for our internal dependencies.
Maybe I misunderstood the usage of the Ignore file. But I do not want to declare all our 600 dependencies in the ignore-file, just to check updates for our 15 internal ones with the group name prefix de.companyname.

This is why I added a filter param to MvnCheck.
This allows filtering the artifact group by a regular expression.

Here is an example of how to only search for an artifact
with the group name suffix com.github.alexisjehan:

- filter com.github.alexisjehan.*

I'm happy for any feedback and suggestions.
Maybe it would be good to also add some formatting hints to the project, so I won't destroy the code format with my merge request.

@AlexisJehan
Copy link
Owner

Thank you for your contribution!

I have started to work on the refactor of ArtifactFilter to improve the reusability for both usages (ignore files and the new filter parameter).
In addition, I think I will improve ignore files by allowing patterns not only for versions, but also for group ids and artifact ids (that will work for the new filter parameter too).

@TobseF
Copy link
Author

TobseF commented Aug 30, 2024

I'm very happy to hear that you adapt my additional filter option. After using it, I also mentioned that your glob-based filter is a better option, than my regex. So I stay tuned for the result, so don't need a special build for our project anymore.

@TobseF TobseF closed this Aug 30, 2024
@AlexisJehan
Copy link
Owner

Released in 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants